This mixed methods study investigated the extent to which preservice teachers' discipline orientations are consistent with their perceptions of what makes an effective teacher. A phenomenological analysis revealed seven characteristics that many preservice teachers considered to reflect effective teaching: student-centered, effective classroom and behavior manager, competent instructor, ethical, enthusiastic about teaching, knowledgeable about subject, and professional. A canonical correlation analysis revealed that the degree of discipline orientation was a predictor of some of these characteristics. Implications are discussed.